<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1714/">https://reviewboard.asterisk.org/r/1714/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is a thread resource leak in SIP-over-TCP or TLS. If a TCP connection fails
(eg. connection refused), then the thread is torn down, but as the thread is created
'joinable' in chan_sip.c:sip_prepare_socket(), and nothing ever pthread_join()'s to it,
we leak about 240Kb and 2x mmap maps.
The issue description copied above was not quite true. There was a joiner, but if the thread
died on its own, it removed the ability to join it. Also the thread may or may not have been
created joinable.
* _sip_tcp_helper_thread() only needs one parameter since the pvt parameter is only passed in as NULL and never used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't have a setup to test the patch. However, by not creating the thread as
joinable fixed the issue for the reporter in his original patch.
Otherwise it compiles. :)
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19203">ASTERISK-19203</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(354045)</span></li>
<li>/branches/1.8/channels/sip/include/sip.h <span style="color: grey">(354045)</span></li>
<li>/branches/1.8/include/asterisk/tcptls.h <span style="color: grey">(354045)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1714/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>