<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1561/">https://reviewboard.asterisk.org/r/1561/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 2nd, 2011, 5:24 p.m., <b>Terry Wilson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I ran into this as well back when testing the realtime stuff, but never got around to fixing it. Looks good. I leave it to your discretion if you think adding a macro for the duplicated logic for generating the string is a good idea. I don't really care much either way.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought about it, but it really meant moving the QUERY up to top, separating them into two #defines (one with and one without commented=0) but now the QUERY is not near enough so you can quickly look at the %conversion specifications. And the other #define QUERY's that would be left would be less consistent and moving them to top would only make things worse.
I left it as-is.</pre>
<br />
<p>- wdoekes</p>
<br />
<p>On November 2nd, 2011, 3:48 p.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2011, 3:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bugs
https://issues.asterisk.org/jira/browse/ASTERISK-18354 and
https://issues.asterisk.org/jira/browse/ASTERISK-18355
concern crashes and failure to return realtime multientry results.
The bug reports should be self-explanatory, but here's a summary:
(1) config_table is not guaranteed to be non-NULL => crash
(2) multientry lookups assume a 'commented' column exists -- it should only do that if the table == config_table</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18354">ASTERISK-18354</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18355">ASTERISK-18355</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/res/res_config_sqlite.c <span style="color: grey">(343156)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1561/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>