<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1437/">https://reviewboard.asterisk.org/r/1437/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Paul Belanger.</div>
<div>By mjordan.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2011, 8:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This tweaks up the SIP dialog checking to allow for SIP history statements to be configurable in the test-config.yaml. Each test can therefore define what entries in the SIP history should be present.
In order to do this, the TestConditionConfig object is now injected into each instance of TestCondition during creation. The derived implementations of TestCondition are responsible for obtaining their specific configuration items out of the TestConditionConfig's yaml configuration object as needed.
This also allows the ThreadTestCondition to be configured with threads to ignore, as testing has shown that some tests will have some threads lingering based on timing issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds the ability to check for SIP dialogs before and after a test run. Before a test run, the presence of any SIP dialogs is treated as a test failure. After a test run, SIP dialogs are allowed to exist, as they will most likely be scheduled for deletion (which could be up to 32 seconds after the test has completed executing). However, the SIP history is checked for each present dialog to ensure that the SIP dialog includes a hangup, and that it was scheduled for destruction with the scheduler.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local machine, including unit tests for parsing of Asterisk CLI responses.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/team/mjordan/test_conditions/trunk/lib/python/asterisk/SipDialogTestCondition.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/test_conditions/trunk/lib/python/asterisk/TestConditions.py <span style="color: grey">(2207)</span></li>
<li>/asterisk/team/mjordan/test_conditions/trunk/lib/python/asterisk/TestConfig.py <span style="color: grey">(2207)</span></li>
<li>/asterisk/team/mjordan/test_conditions/trunk/lib/python/asterisk/ThreadTestCondition.py <span style="color: grey">(2207)</span></li>
<li>/asterisk/team/mjordan/test_conditions/trunk/tests/apps/voicemail/authenticate_nominal/test-config.yaml <span style="color: grey">(2207)</span></li>
<li>/asterisk/team/mjordan/test_conditions/trunk/tests/apps/voicemail/check_voicemail_new_user/test-config.yaml <span style="color: grey">(2207)</span></li>
<li>/asterisk/team/mjordan/test_conditions/trunk/tests/apps/voicemail/check_voicemail_nominal/test-config.yaml <span style="color: grey">(2207)</span></li>
<li>/asterisk/team/mjordan/test_conditions/trunk/tests/apps/voicemail/func_vmcount/test-config.yaml <span style="color: grey">(2207)</span></li>
<li>/asterisk/team/mjordan/test_conditions/trunk/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml <span style="color: grey">(2207)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1437/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>