<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1311/">https://reviewboard.asterisk.org/r/1311/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Other than Jonathan's comment about the structure name, I think this looks great, and solves a long-standing code quality issue. Nice work.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On July 6th, 2011, 8:06 a.m., Tilghman Lesher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Kevin Fleming.</div>
<div>By Tilghman Lesher.</div>
<p style="color: grey;"><i>Updated July 6, 2011, 8:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A change to move a module 'use' to a 'depend' when weak linking is not detected was made recently. Kpfleming suggested an alternative approach, which is contained in this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Verified that modules get moved correctly and external 'use' libraries do not when 'weak' link detection is removed.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18062">ASTERISK-18062</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/linkedlists.h <span style="color: grey">(905)</span></li>
<li>trunk/menuselect.h <span style="color: grey">(905)</span></li>
<li>trunk/menuselect.c <span style="color: grey">(905)</span></li>
<li>trunk/menuselect_curses.c <span style="color: grey">(905)</span></li>
<li>trunk/menuselect_gtk.c <span style="color: grey">(905)</span></li>
<li>trunk/menuselect_newt.c <span style="color: grey">(905)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1311/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>