<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1231/">https://reviewboard.asterisk.org/r/1231/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 25th, 2011, 2:07 p.m., <b>Alec Davis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">using my nasty looping channels dialplan, still able to get a deadlock in chan_local, by calling 10030, ignoring the exceptionally long queue to xyz.
This was existed before.
=== -------------------------------------------------------------------
===
=== Thread ID: 0xb5043b70 [Thread 5879]: (pbx_thread started at [ 5211] pbx.c ast_pbx_start())
=== ---> Lock #0 (channel.c): MUTEX 4751 ast_write chan 0x1047fa30 (1)
=== ---> Lock #1 (chan_local.c): MUTEX 592 local_write p 0x10478718 (1)
=== ---> Waiting for Lock #2 (chan_local.c): MUTEX 336 local_bridgedchannel p 0x10486978 (1)
=== --- ---> Locked Here: chan_local.c line 592 (local_write)
=== -------------------------------------------------------------------
===
=== Thread ID: 0xb5007b70 [Thread 5880]: (pbx_thread started at [ 5211] pbx.c ast_pbx_start())
=== ---> Lock #0 (channel.c): MUTEX 4751 ast_write chan 0x1048c830 (1)
=== ---> Lock #1 (chan_local.c): MUTEX 592 local_write p 0x10486978 (1)
=== ---> Lock #2 (chan_local.c): MUTEX 513 check_bridge p->chan->_bridge 0x104957f8 (2)
=== ---> Lock #3 (chan_local.c): MUTEX 515 check_bridge p->owner 0x10488690 (2)
=== ---> Waiting for Lock #4 (chan_local.c): MUTEX 336 local_bridgedchannel p 0x10478718 (1)
=== --- ---> Locked Here: chan_local.c line 592 (local_write)
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, that one is easy. I'll fix it.</pre>
<br />
<p>- David</p>
<br />
<p>On May 25th, 2011, 9:49 a.m., David Vossel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Vossel.</div>
<p style="color: grey;"><i>Updated 2011-05-25 09:49:42</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Introduces the awesome_locking() function and cleans up all the unnecessary deadlock avoidance junk we do.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I made a call. Obviously more testing is required under load.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_local.c <span style="color: grey">(320715)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1231/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>