<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1210/">https://reviewboard.asterisk.org/r/1210/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Terry Wilson, David Vossel, and Rob Gagnon.</div>
<div>By Rob Gagnon.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is the altered version of Terry's patch for chan_sip from review 1207 (which was for branch 1.6.2)
This patch is for tag 1.8.3.3, which should apply pretty clean to trunk and to branch 1.8
5 alterations were done to fit the 1.8 version of chan_sip.c. The other 21 hunks applied either with simple offsets, or fuzz 1/2.
1) a. remove peer_is_marked() function
b. move unlink_marked_peers_from_tables()
c. move unlink_peer_from_tables()
2) manual patch of the code in sip_cancel_destroy()
3) find_call() did not need <<< p = dialog_unref(p, "pedantic linear search for dialog unref to restart search"); >>> due to the new iterator in place of the original goto loop.
4) changed the comment from "/* returns p locked and ref'd */" to "/* returns p ref'd */"
5) manunal patch of the code in start_session_timer()</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/view.php?id=17255">17255</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/tags/1.8.3.3/channels/chan_sip.c <span style="color: grey">(318283)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1210/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>