<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1147/">https://reviewboard.asterisk.org/r/1147/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In general, I think this looks awesome. I'll come back and look through some of the bridging stuff some more as time permits, but honestly I'm not too concerned because it's isolated code. Nothing else uses this stuff. I think it's time we get this into trunk and get more people trying it out and giving feedback.</pre>
<br />
<p>- Russell</p>
<br />
<p>On March 28th, 2011, 3:47 p.m., David Vossel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Vossel.</div>
<p style="color: grey;"><i>Updated 2011-03-28 15:47:43</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The new ConfBridge application. It's kind of a big deal.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All confbridge.conf features have been tested.
Load tested at sample rates ranging from 8-48khz.
AMI actions/events tested
CLI commands tested</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/configs/confbridge.conf.sample <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/bridging.h <span style="color: grey">(311748)</span></li>
<li>/trunk/include/asterisk/bridging_features.h <span style="color: grey">(311748)</span></li>
<li>/trunk/include/asterisk/bridging_technology.h <span style="color: grey">(311748)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(311748)</span></li>
<li>/trunk/include/asterisk/dsp.h <span style="color: grey">(311748)</span></li>
<li>/trunk/main/bridging.c <span style="color: grey">(311748)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(311748)</span></li>
<li>/trunk/main/dsp.c <span style="color: grey">(311748)</span></li>
<li>/trunk/apps/confbridge/include/confbridge.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/bridges/bridge_builtin_features.c <span style="color: grey">(311748)</span></li>
<li>/trunk/bridges/bridge_softmix.c <span style="color: grey">(311748)</span></li>
<li>/trunk/apps/confbridge/conf_config_parser.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/apps/app_confbridge.c <span style="color: grey">(311748)</span></li>
<li>/trunk/CHANGES <span style="color: grey">(311748)</span></li>
<li>/trunk/UPGRADE.txt <span style="color: grey">(311748)</span></li>
<li>/trunk/apps/Makefile <span style="color: grey">(311748)</span></li>
<li>/trunk/res/res_musiconhold.c <span style="color: grey">(311748)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1147/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>