<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1132/">https://reviewboard.asterisk.org/r/1132/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1132/diff/1/?file=15774#file15774line4304" style="color: black; font-weight: bold; text-decoration: underline;">/tags/1.8.2/apps/app_meetme.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int conf_exec(struct ast_channel *chan, const char *data)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4304</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ew"> </span> <span class="n">ast_test_flag64</span><span class="p">(</span><span class="o">&</span><span class="n">confflags</span><span class="p">,</span> <span class="n">CONFFLAG_ADMIN</span><span class="p">))</span> <span class="o">||</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4304</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ew"> </span> <span class="n">ast_test_flag64</span><span class="p">(</span><span class="o">&</span><span class="n">confflags</span><span class="p">,</span> <span class="n">CONFFLAG_ADMIN</span><span class="p">))</span> <span class="o">||</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4305</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ew"> </span> <span class="p">(</span><span class="o">!</span><span class="n">ast_strlen_zero</span><span class="p">(</span><span class="n">cnf</span><span class="o">-></span><span class="n">pin</span><span class="p">)</span> <span class="o">&&</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4305</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ew"> </span> <span class="p">(</span><span class="o">!</span><span class="n">ast_strlen_zero</span><span class="p">(</span><span class="n">cnf</span><span class="o">-></span><span class="n">pin</span><span class="p">)</span> <span class="o">&&</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4306</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ew"> </span><span class="ew"> </span> <span class="n">ast_strlen_zero</span><span class="p">(</span><span class="n">cnf</span><span class="o">-></span><span class="n">pinadmin</span><span class="p">)</span> <span class="o">&&</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4306</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ew"> </span><span class="ew"> </span> <span class="n">ast_strlen_zero</span><span class="p">(</span><span class="n">cnf</span><span class="o">-></span><span class="n">pinadmin</span><span class="p">)</span> <span class="o">&&</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4307</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ew"> </span><span class="ew"> </span> <span class="n">ast_test_flag64</span><span class="p">(</span><span class="o">&</span><span class="n">confflags</span><span class="p">,</span> <span class="n">CONFFLAG_ADMIN</span><span class="p">)))</span> <span class="o">&&</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4307</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ew"> </span><span class="ew"> </span> <span class="n">ast_test_flag64</span><span class="p">(</span><span class="o">&</span><span class="n">confflags</span><span class="p">,</span> <span class="n">CONFFLAG_ADMIN</span><span class="p">)))</span> <span class="o">&&</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4308</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">(</span><span class="o">!</span><span class="p">(</span><span class="n">cnf</span><span class="o">-></span><span class="n">users</span> <span class="o">==</span> <span class="mi">0</span> <span class="o">&&</span> <span class="n">cnf</span><span class="o">-></span><span class="n">isdynamic</span><span class="p">))<span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4308</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p"><span class="hl">(</span>(</span><span class="o">!</span><span class="p">(</span><span class="n">cnf</span><span class="o">-></span><span class="n">users</span> <span class="o">==</span> <span class="mi">0</span> <span class="o">&&</span> <span class="n">cnf</span><span class="o">-></span><span class="n">isdynamic</span><span class="p">))</span><span class="hl"> </span><span class="o"><span class="hl">||</span></span><span class="hl"><span class="ew"> </span></span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4309</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ew"> </span><span class="n">ast_test_flag64</span><span class="p">(</span><span class="o">&</span><span class="n">confflags</span><span class="p">,</span> <span class="n">CONFFLAG_ALWAYSPROMPT</span><span class="p">)))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Red blobs, since we are here.</pre>
</div>
<br />
<p>- Paul</p>
<br />
<p>On March 3rd, 2011, 3:33 p.m., Brett Bryant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Brett Bryant.</div>
<p style="color: grey;"><i>Updated 2011-03-03 15:33:41</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes a bug with MeetMe behavior where the 'P' option for always prompting for a pin is ignored for the first caller.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested various meetme configurations before and after the patch, and they all work as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/tags/1.8.2/apps/app_meetme.c <span style="color: grey">(309343)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1132/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>