<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1047/">https://reviewboard.asterisk.org/r/1047/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Russell Bryant.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated 2011-01-14 17:13:38.468989</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated patch.
1) Made NULL tech code conditional with a big comment describing it and its consequences.
2) Fixed feature_request_and_dial() to defer frames for the transferee like autoservice.
3) Committed the unrelated wrong variable fix.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Issue 17999
1) A calls B. B answers.
2) B using DTMF dial *2 (code in features.conf for attended transfer).
3) A hears MOH. B dial number C
4) C ringing. A hears MOH.
5) B hangup. A still hears MOH. C ringing.
5) A hangup. C still ringing until "atxfernoanswertimeout" expires.
Problem: When A and B hangup C is still ringing.
Issue 18395
SIP call limit of B is 1
1. A call B, B answered
2. B *2(atxfer) call C, C ringing (no answer)
3. B hangup
4. C cancel call
5. Call to B fails because B has reached its call limit.
Because B reached its call limit, it cannot do anything until the transfer it started completes.
Issue 17273
Same scenario as issue 18395 but party B is an FXS port.
Party B cannot do anything until the transfer it started completes. If B goes back off hook before C answers, B hears ringback instead of the expected dialtone.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Party A - transferee
Party B - transferer
Party C - target of transfer
A and B are connected (It does not matter who called whom for these tests.)
B requests attended transfer feature by dialing *2 feature.
B fails to dial party C (Check A & B audio)
B dials wrong number (Check A & B audio)
B cancels call to party C with '*' (Check A & B audio)
C is the parking extension (Outside the scope of this patch)
C does not answer before timeout (Check A & B audio)
C is busy (Check A & B audio)
A hangs up before C answers (Check if A is completely released)
        (If A is an analog port it is dead until the user
         configured xferfailsound completes playing.)
        (Test case is issue 17273 and issue 18395 related)
C answers before B hangup (Attended transfer)
        A still online
                C hangs up first (Check A & B audio)
                B hangs up first (Check A & C audio)
        A hangs up (Check if A is completely released)
                (If A is an analog port it is dead until B or C hangs up)
                (Test case is issue 17273 and issue 18395 related)
                C hangs up first (Check B audio)
                B hangs up first (Check C audio)
B hangs up before C answers (Blonde transfer) (Check if B is completely released)
        (Test case is issue 17273 and issue 18395)
        A hangs up (C should quit ringing immediately)
                (Test case is issue 17999)
        C answers (Check A & C audio)
        C does not answer before timeout
                A hangs up when B redialed (B should quit ringing immediately)
                        (Test case is issue 17999 related)
                B answers recall (Check A & B audio)
                A hangs up when sleeping before redialing C (A should be released immediately)
                        (Test case is issue 17999 related)
                A hangs up when C redialed (C should quit ringing immediately)
                        (Test case is issue 17999 related)
                C answers recall (Check A & C audio)
                Noone answers (Check A audio)
Tests passed with exceptions noted.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/view.php?id=17273">17273</a>,
<a href="https://issues.asterisk.org/view.php?id=17999">17999</a>,
<a href="https://issues.asterisk.org/view.php?id=18395">18395</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.6.2/main/features.c <span style="color: grey">(302003)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1047/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>