<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1057/">https://reviewboard.asterisk.org/r/1057/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Russell</p>
<br />
<p>On December 14th, 2010, 11:23 a.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated 2010-12-14 11:23:45</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After trying to debug tests/mixmonitor failures under FreeBSD, it finally occurred to me the system didn't have a sound card. It seems under Linux, Asterisk will still create audio files (they are empty), but under FreeBSD the file does not get created. So, we can assume chan_oss.so requires a sound card, and if none is present on the system, we can skip all tests that require it.
For now, we check if we can open dev/dsp.
Additionally, added logic to mixmonitor/run-test and now it successfully passes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local, and FreeBSD box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/runtests.py <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/cdr/cdr_unanswered_yes/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/cdr/cdr_userfield/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/cdr/console_dial_sip_answer/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/cdr/console_dial_sip_busy/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/cdr/console_dial_sip_congestion/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/cdr/console_dial_sip_transfer/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/cdr/console_fork_after_busy_forward/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/cdr/console_fork_before_dial/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/cdr/nocdr/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/directed_pickup/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/mixmonitor/configs/ast1/extensions.conf <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/mixmonitor/configs/ast1/manager.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/mixmonitor/run-test <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/mixmonitor/test-config.yaml <span style="color: grey">(1161)</span></li>
<li>asterisk/trunk/tests/mixmonitor_audiohook_inherit/test-config.yaml <span style="color: grey">(1161)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1057/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>