<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1035/">https://reviewboard.asterisk.org/r/1035/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 24th, 2010, 8:21 a.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1035/diff/2/?file=13224#file13224line87" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/trunk/tests/fastagi/configs/extensions.conf</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">71</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">exten => _5XX,n,Wait(15)</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm having trouble understanding this 15 second wait. I'd like to remove it if possible, since it is not a good method to wait for the other side to do something.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Erin (the author of the tests) will be back next week. You should talk to her about it if it can wait until then.</pre>
<br />
<p>- Russell</p>
<br />
<p>On November 24th, 2010, 8:15 a.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Erin Spiceland.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated 2010-11-24 08:15:34</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The current fastagi tests are dependent on the speed of the host computer, on a slow system they will usually fail. The 2nd reactor has not full started but the 1st has already started the test. I've now added 2-way communication between the dialplans. Since side A starts first, we now WaitExten(10) expecting side B to send DTMF (it confirms B is ready).
I also noticed we don't properly stop reactor A, which was an issue on the FreeBSD host. It basically created a deadlock on 'core stop now', eventually the testsuite had to kill the process to stop asterisk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">local testing and on slower freebsd box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/fastagi/configs/extensions.conf <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/connect/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/control-stream-file/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/database/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/execute/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/get-data/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/hangup/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/record-file/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/say-alpha/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/say-date/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/say-datetime/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/say-digits/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/say-number/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/say-phonetic/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/say-time/run-test <span style="color: grey">(930)</span></li>
<li>asterisk/trunk/tests/fastagi/stream-file/run-test <span style="color: grey">(930)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1035/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>