<div>
<style type="text/css">
.successful a, .successful a:visited, .successful a:link, .successful a:hover,.successful a:active {color:#393}
.failed a, .failed a:visited, .failed a:link, .failed a:hover,.failed a:active {color:#d62829}
td a, td a:link, td a:visited, td a:hover, td a:active {background:transparent;font-family: Arial, sans-serif;text-decoration:underline;}
td a:link {color:#369;}
td a:visited {color:#444;}
td a:hover, td a:active {color:#036;}
td a:hover {text-decoration:none;}
</style>
<font size="2" color="black" face="Arial, Helvetica, sans-serif" style="font-family: Arial, sans-serif;font-size: 13px;color:#000">
<table align="center" border="0" cellpadding="5" cellspacing="0" width="98%">
<tr>
<td style="vertical-align:top">
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#e4f5e3;border-top:1px solid #b4e2b4;border-bottom:1px solid #b4e2b4;color:#393;">
<tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/jt/icn_plan_passed.gif" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#393;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST-TRUNK-317/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#393">AST-TRUNK-317</a>
<span class="successful" style="font-family: Arial, sans-serif; font-size: 14px;"> was successful.</span>
<span class="successful" style="font-family: Arial, sans-serif; font-size: 13px;">
<br/>Code has been updated by <a href="http://bamboo.asterisk.org/browse/user/kpfleming">Kevin P. Fleming</a>.
<br/><strong>34</strong> tests in total.
</span>
</td>
</tr>
</table>
<br>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST-TRUNK-317/commit" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Code Changes</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST-TRUNK-317/commit" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">See full change details</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
<img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
<a href="http://bamboo.asterisk.org/browse/user/kpfleming" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
Kevin P. Fleming</a><br>
Improve handling of T.38 re-INVITEs that arrive before a T.38-capable<br/>
application is executing on a channel.<br/>
<br/>
This patch addresses an issue found during working with end-users<br/>
using res_fax. If an incoming call is answered in the dialplan, or<br/>
jumps to the 'fax' extension due to reception of a CNG tone (with<br/>
faxdetect enabled), and then the remote endpoint sends a T.38<br/>
re-INVITE, it is possible for the channel's T.38 state to be<br/>
'T38_STATE_NEGOTIATING' when the application starts up. Unfortunately,<br/>
even if the application wants to use T.38, it can't respond to the<br/>
peer's negotiation request, because the AST_CONTROL_T38_PARAMETERS<br/>
control frame that chan_sip sent originally has been lost, and the<br/>
application needs the content of that frame to be able to formulate a<br/>
reply.<br/>
<br/>
This patch adds a new 'request' type to AST_CONTROL_T38_PARAMETERS,<br/>
AST_T38_REQUEST_PARMS. If the application sends this request, chan_sip<br/>
will re-send the original control frame (with<br/>
AST_T38_REQUEST_NEGOTIATE as the request type), and the application<br/>
can respond as normal. If this occurs within the five second timeout<br/>
in chan_sip, the automatic cancellation of the peer reinvite will be<br/>
stopped, and the application will 'own' the negotiation process from<br/>
that point onwards.<br/>
<br/>
This also improves the code path in chan_sip to allow sip_indicate(),<br/>
when called for AST_CONTROL_T38_PARAMETERS, to be able to return a<br/>
non-zero response, which should have been in place before since the<br/>
control frame *can* fail to be processed properly. It also modifies<br/>
ast_indicate() to return whatever result the channel driver returned<br/>
for this control frame, rather than converting all non-zero results<br/>
into '-1'. Finally, the new request type intentionally returns a<br/>
positive value, so that an application that sends<br/>
AST_T38_REQUEST_PARMS can know for certain whether the channel driver<br/>
accepted it and will be replying with a control frame of its own, or<br/>
whether it was ignored (if the sip_indicate()/ast_indicate() path had<br/>
properly supported failure responses before, this would not be<br/>
necessary).<br/>
<br/>
This patch also modifies res_fax to take advantage of the new request.<br/>
<br/>
In addition, this patch makes sip_t38_abort() actually lock the<br/>
private structure before doing its work... bad programmer, no donut.<br/>
<br/>
This patch also enhances chan_sip's 'faxdetect' support to allow<br/>
triggering on T.38 re-INVITEs received as well as CNG tone detection.<br/>
<br/>
Review: <a href="https://reviewboard.asterisk.org/r/556/">https://reviewboard.asterisk.org/r/556/</a><br/>
<br/>
</td>
<td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
(254450)
</td></tr>
</table><br>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST-TRUNK-317/log" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Error Summary</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST-TRUNK-317/log" style="font-family: Arial, sans-serif; font-size: 13px;color:#036">See full build log</a>
<img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#f2f2f2;border-top:1px solid #d9d9d9;border-bottom:1px solid #d9d9d9;color:#000;margin-top:5px;padding:10px">
<tr>
<td width="100%" style="font-family:'Courier New', Courier, monospace; font-size: 12px; color:#000;vertical-align:top">
src/lfs.c: In function 'lfs_g_setmode':<br/>
</td>
</tr>
<tr>
<td width="100%" style="font-family:'Courier New', Courier, monospace; font-size: 12px; color:#000;vertical-align:top">
src/lfs.c:235: warning: unused parameter 'f'<br/>
</td>
</tr>
<tr>
<td width="100%" style="font-family:'Courier New', Courier, monospace; font-size: 12px; color:#000;vertical-align:top">
src/lfs.c:235: warning: unused parameter 'arg'<br/>
</td>
</tr>
</table>
<br />
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td colspan="2" align="center" style="font-family: Arial, sans-serif;text-align:center;font-size:11px;font-weight:bold;color:#999;vertical-align:top;padding:20px;padding-bottom:10px">
Email generated by <a href="http://bamboo.asterisk.org" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">Atlassian Bamboo</a> - if you wish to stop receiving these emails edit your <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">notify your administrator</a>
</td>
</tr>
<tr><td colspan="2" align="center" style="font-family: Arial, sans-serif;text-align:center;font-size:11px;font-weight:bold;color:#999;vertical-align:top">
<a href="http://www.atlassian.com/software/ideconnector/" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">Want this information in your IDE?</a>
</td></tr>
</table>
</td>
<td width="150" style="vertical-align:top">
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
Actions
</td>
</tr>
</table>
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#f5f9fc;border-bottom:1px solid #bbd0e5;">
<tr>
<td style="font-family: Ariel, sans-serif; font-size: 13px; color:#036;vertical-align:top;padding:5px 10px;line-height:1.7">
<a href="http://bamboo.asterisk.org/browse/AST-TRUNK-317/" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">View Online</a>
<br>
<a href="http://bamboo.asterisk.org/browse/AST-TRUNK-317/comment" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">Add Comments</a>
<br>
<a href="http://bamboo.asterisk.org/browse/AST-TRUNK-317/artifact" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">View Artifacts</a>
<br>
<a href="http://bamboo.asterisk.org/download/AST-TRUNK/build_logs/AST-TRUNK-317.log" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">Download Logs</a>
<br>
</td>
</tr>
</table>
</td>
<tr>
</table>
</font>
</div>