<br><br><div class="gmail_quote">On Thu, Apr 9, 2009 at 10:52 AM, Russell Bryant <span dir="ltr"><<a href="mailto:russell@digium.com">russell@digium.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Greetings,<br>
<br>
I have added some reviewboard usage guidelines to our doxygen<br>
documentation. You can find the current version of the documentation here:<br>
<br>
<a href="http://www.asterisk.org/doxygen/trunk/Reviewboard.html" target="_blank">http://www.asterisk.org/doxygen/trunk/Reviewboard.html</a><br>
<br>
One notable bit that is not in the guidelines today, but I think should<br>
be considered, is guidelines for when it is _required_ for code to be<br>
posted for review before being merged.<br>
<br>
After seeing how many bugs have been found and fixed through in depth<br>
code review on reviewboard before making it in to Asterisk, I am<br>
inclined to say that I think _all_ non-trivial changes should be put<br>
through reviewboard and require at least one sign off from another<br>
committer before being merged.<br>
<br>
What do others think about this?</blockquote><div><br>Sounds like a good idea. Since it already is kind of the non-official policy, the only thing that would really be changing is the documentation supporting it.<br><br>
--<br>Jeff Peeler<br>Digium, Inc. | Software Developer<br>445 Jan Davis Drive NW - Huntsville, AL 35806 - USA<br>Check us out at <a href="http://www.digium.com">www.digium.com</a> & <a href="http://www.asterisk.org">www.asterisk.org</a><br>
</div></div><br>