[asterisk-dev] [Code Review] 4394: chan_pjsip: Port over attribute passthrough tests and add test for sprop-parameter-sets.

Kevin Harwell reviewboard at asterisk.org
Fri Jan 30 12:07:46 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4394/#review14397
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Harwell


On Jan. 30, 2015, 6:35 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4394/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 6:35 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24616
>     https://issues.asterisk.org/jira/browse/ASTERISK-24616
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is a port over of the chan_sip SDP attribute passthrough tests. They've been copied as-is except for the Asterisk configuration. I've also added a test to SDP offer/answer which includes sprop-parameter-sets usage as we did not have one previously.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/tests.yaml 6340 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/multiple-media-stream/audio-video/basic/test-config.yaml 6340 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/multiple-media-stream/audio-video/basic/sipp/uac-basic-codecs-with-attributes.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_B_speex.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_B_h264.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_B_h263.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_A_speex.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_A_h264.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_A_h263.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4394/diff/
> 
> 
> Testing
> -------
> 
> Ran tests. They ran.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150130/6ea13e95/attachment.html>


More information about the asterisk-dev mailing list