[asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4372/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 7:33 p.m.)


Review request for Asterisk Developers and Jonathan Rose.


Changes
-------

Added a #define for the maximum length of bridge/user/menu profiles.


Bugs: ASTERISK-24723
    https://issues.asterisk.org/jira/browse/ASTERISK-24723


Repository: Asterisk


Description
-------

When issuing a 'confbridge list XXXX' CLI command, the resulting output no longer displays the menu associated with a ConfBridge participant:

 Channel                        Flags  User Profile     Bridge Profile   Menu             CallerID
============================== ====== ================ ================ ================ ================
PJSIP/1601-00000004                   default_user     default_bridge                    1601

The issue was caused by ASTERISK-22760. When that patch was done, it removed the copying of the menu name associated with the user from the actual user profile.

This patch fixes the issue by copying the menu name over to the user profile when the menu hooks are applied to the user. Since that function now does a little bit more than just apply the hooks, the name of the function has been changed to cover the copying of the menu name over as well.

In addition, there is a disparity between the menu name length as it is stored on the conf_menu structure and the confbridge_user structure; this patch makes the lengths match so that a strcpy can be used.


Diffs (updated)
-----

  /branches/13/apps/confbridge/include/confbridge.h 431019 
  /branches/13/apps/confbridge/conf_config_parser.c 431019 

Diff: https://reviewboard.asterisk.org/r/4372/diff/


Testing
-------

Ran the CLI command. The output now shows the menu associated with the user.


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150127/db8b6155/attachment.html>