[asterisk-dev] [Code Review] 4369: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v13 version)

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4369/#review14282
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Jan. 23, 2015, 5:55 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4369/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 5:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24719
>     https://issues.asterisk.org/jira/browse/ASTERISK-24719
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Starting and stopping conference recording more than once causes the
> recording channels to be leaked.  For v13 the channels also show up in the
> CLI "core show channels" output.
> 
> * Reworked and simplified the recording channel code to use
> ast_bridge_impart() instead of managing the recording thread in the
> ConfBridge code.  The recording channel's ref handling easily falls into
> place and other off nominal code paths get handled better as a result.
> 
> v11 version of patch: https://reviewboard.asterisk.org/r/4368/
> 
> 
> Please ignore the change in cli.c.  That change is for a future patch.
> 
> 
> Diffs
> -----
> 
>   /branches/13/main/cli.c 431064 
>   /branches/13/apps/confbridge/include/confbridge.h 431064 
>   /branches/13/apps/app_confbridge.c 431064 
> 
> Diff: https://reviewboard.asterisk.org/r/4369/diff/
> 
> 
> Testing
> -------
> 
> With the test:
> The confbridge testsuite tests still pass.
> Manual testing no longer has the recording channel ref leak.
> 
> The v13 version of the patch no longer has the CBRec channel left in the
> CLI "core show channels" output.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150126/1c5ad367/attachment.html>