[asterisk-dev] [Code Review] 4095: Add a prompt to be read to the "winner" when a call is connected through app_followme

[Graham Mainwaring]

> On Jan. 21, 2015, 5 p.m., Matt Jordan wrote:
> > Thanks for the contribution!
> > 
> > The only finding I have is to add an entry in the CHANGES file in trunk for the new feature.

Done - thanks!


> On Jan. 21, 2015, 5 p.m., Matt Jordan wrote:
> > /trunk/apps/app_followme.c, lines 362-365
> > <https://reviewboard.asterisk.org/r/4095/diff/1/?file=68420#file68420line362>
> >
> >     Just as an FYI, we now always use braces, even in single line if-statements. This code predates that entry in the Coding Guidelines (and probably predates the Coding Guidelines, for that matter) - so matching the existing coding style in this module is okay.
> >     
> >     If you feel like adding {} here, however, that'd be fine as well.

Matt, I understand what you are saying, but since this file already doesn't follow the coding standards, I think it is better to match the existing style than to wedge in one weirdly different clause - or turn this patch into a rewrite of the whole block.


- Graham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4095/#review14254
-----------------------------------------------------------


On Jan. 20, 2015, 5:16 a.m., Graham Mainwaring wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4095/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 5:16 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24372
>     https://issues.asterisk.org/jira/browse/ASTERISK-24372
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds the ability to configure a prompt which will be read to the "winner" who pressed 1 (or the configured value) and received the call.
> 
> The context of this is that I have users who only receive outbound follow-me calls occasionally. These users have complained that when they are connected to the inbound caller, they don't always remember to say hello as if the call just arrived, so there is an awkward moment where the two parties figure out they are connected.
> 
> My prompt here says "Connecting. After the beep, please say hello to the caller. <beep>." This reminds the follow-me winner that they ought to say hello.
> 
> I have configured this with a default of silence/0 so that the system's behavior will not change for anyone who does not have this configured.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/samples/followme.conf.sample 425984 
>   /trunk/apps/app_followme.c 425984 
> 
> Diff: https://reviewboard.asterisk.org/r/4095/diff/
> 
> 
> Testing
> -------
> 
> I have been running this in production for about three years with no issues. I have not done any sort of regression testing against other Asterisk features or in configurations other than my own production server.
> 
> 
> Thanks,
> 
> Graham Mainwaring
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150122/dfedd04e/attachment.html>