[asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4355/
-----------------------------------------------------------

(Updated Jan. 19, 2015, 7:50 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed syntatically valid (but very wrong) call to ao2_callback.


Bugs: ASTERISK-24640 and ASTERISK-24673
    https://issues.asterisk.org/jira/browse/ASTERISK-24640
    https://issues.asterisk.org/jira/browse/ASTERISK-24673


Repository: Asterisk


Description
-------

When the SIP registrations were migrated to using ao2 in what was then trunk, the explicit destruction of the registrations on module reload was removed and not replaced with an ao2 equivalent. Debugging done by Stefan Engström, the issue reporter, on ASTERISK-24673 confirmed that the reference in the registry_list container was being leaked.

Since the purpose of cleanup_all_regs is to prep a registration for destruction, this function has been converted to being an ao2_callback function callback, and an ao2_callback with OBJ_MULTIPLE | OBJ_NODATA | OBJ_UNLINK is now used to invoke the function. This cleans up each registration, but also removes it from the registration container registry_list.


Diffs (updated)
-----

  /branches/13/channels/chan_sip.c 430794 

Diff: https://reviewboard.asterisk.org/r/4355/diff/


Testing
-------

Created an outbound registration to a SIP trunk. Confirmed that Asterisk was registered. Commented out the "register" line sip.conf, reloaded, and confirmed that the registration was gone.

Stefan tested the patch independently and also confirmed that it fixed it on his test system.


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150120/c0791e9b/attachment.html>