[asterisk-dev] [Code Review] 4331: res_pjsip / res_pjsip_multihomed: Use the correct transport and addressing information on UAS sessions

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4331/#review14217
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Jan. 16, 2015, 11:05 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4331/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 11:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24615
>     https://issues.asterisk.org/jira/browse/ASTERISK-24615
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The first thing this patch fixes is UAS dialogs. Previously if a transport was configured on an endpoint and an inbound session was created there was no guarantee that requests sent on the dialog would use the correct transport and address information. This has now been fixed so an explicitly configured transport is taken into account.
> 
> The second thing this patch fixes is res_pjsip_multihomed. The res_pjsip_multihomed module attempts to determine what transport a message should go out on and what addressing information should go into the message itself. In a scenario where multiple transports exist bound to the same IP address but a different port the code would incorrectly alter the transport and change the message to the wrong transport. This change makes the res_pjsip_multihomed module smarter so it will only change the transport and address information in the message when it is possible and makes sense.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_multihomed.c 430683 
>   /branches/13/res/res_pjsip.c 430683 
> 
> Diff: https://reviewboard.asterisk.org/r/4331/diff/
> 
> 
> Testing
> -------
> 
> Ran test and confirmed it failed without patch, passed with patch.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150118/6095810d/attachment.html>