[asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4347/#review14211
-----------------------------------------------------------



branches/13/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/4347/#comment24669>

    ast_sockaddr_resolve() appears to have a path where it does not initialize hostaddr. This means that this ast_free() could be called on junk memory on a specific off-nominal path. Your best bet for fixing this would be to initialize hostaddr to NULL inside this block.
    
    The same goes for the other place where you are adding the ast_free(hostaddr) in chan_iax2.c



branches/13/res/res_pjsip_pubsub.c
<https://reviewboard.asterisk.org/r/4347/#comment24671>

    This change seems incorrect. When we call pjsip_evsub_terminate(), the PJ_TRUE parameter means we should get called back when the subscription terminates. The reference that the pjsip_evsub has to the subscription tree should then get decremented in pubsub_on_evsub_state().
    


- Mark Michelson


On Jan. 15, 2015, 7:15 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4347/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 7:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24693
>     https://issues.asterisk.org/jira/browse/ASTERISK-24693
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch fixes a few memory leaks that were found in Asterisk.
> 
> 
> Diffs
> -----
> 
>   branches/13/rest-api-templates/param_parsing.mustache 430684 
>   branches/13/res/res_stasis.c 430684 
>   branches/13/res/res_pjsip_pubsub.c 430684 
>   branches/13/res/res_pjsip_mwi.c 430684 
>   branches/13/res/res_pjsip/pjsip_global_headers.c 430684 
>   branches/13/res/res_ari_events.c 430684 
>   branches/13/res/res_ari_endpoints.c 430684 
>   branches/13/res/res_ari_channels.c 430684 
>   branches/13/res/parking/parking_applications.c 430684 
>   branches/13/channels/chan_iax2.c 430684 
> 
> Diff: https://reviewboard.asterisk.org/r/4347/diff/
> 
> 
> Testing
> -------
> 
> Some manual testing done along with inspection of log files and malloc_debug data.  Also ran relevant unit and testsuite tests.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150116/d638ab78/attachment-0001.html>