[asterisk-dev] [Code Review] 4349: Asterisk: Creating a named ARI bridge twice causes a crash

[Ashley Sanders]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4349/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-24560
    https://issues.asterisk.org/jira/browse/ASTERISK-24560


Repository: Asterisk


Description
-------

Currently in ARI (Asterisk REST Interface), posting to the: /ari/bridges/{bridgeId} endpoint without specifying a value for the [name] query parameter, will crash Asterisk if the bridge you are attempting to create (or update) has the same ID as an existing bridge. The internal mechanism of the POST operation interprets a null value for name, thus resulting in an error condition that crashes Asterisk.

The first step in resolving this was to construct tests to ensure that Asterisk behaves as expected when submitting requests for creating a new bridge when a bridge with the same ID already exists in memory. The expected behavior is to reject such requests and return an HTTP status code of 500 (Internal Server Error). 

You can find the review for the test suite at: https://reviewboard.asterisk.org/r/4348


Diffs
-----

  ./branches/13/res/ari/resource_bridges.c 430163 
  ./branches/13/main/strings.c 430163 
  ./branches/13/include/asterisk/strings.h 430163 

Diff: https://reviewboard.asterisk.org/r/4349/diff/


Testing
-------


Thanks,

Ashley Sanders

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150115/6e0b832f/attachment.html>