[asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process
Mark Michelson
reviewboard at asterisk.org
Wed Jan 14 17:36:17 CST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4328/#review14190
-----------------------------------------------------------
Ship it!
As far as I'm concerned this is looking much better, and you've addressed my complaints, so ship that mother.
- Mark Michelson
On Jan. 12, 2015, 1:33 p.m., Joshua Colp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4328/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2015, 1:33 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> The transport selection process of PJSIP (and by extension some of our own logic) can be a dark dark thing. To help illuminate what happens I have created a wiki page[1] which goes through (based on the message type) the process by which a transport is chosen and how it can potentially change.
>
> Stuff to look at:
> 1. Is this detailed enough?
> 2. Can you follow it? If not, how could it be made clearer?
> 3. Are there additional common issues that should be covered?
>
> [1] https://wiki.asterisk.org/wiki/display/~jcolp/Transport+Selection
>
>
> Diffs
> -----
>
>
> Diff: https://reviewboard.asterisk.org/r/4328/diff/
>
>
> Testing
> -------
>
> I opened the wiki page. It opened.
>
>
> Thanks,
>
> Joshua Colp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150114/0594ffb9/attachment.html>
More information about the asterisk-dev
mailing list