[asterisk-dev] [Code Review] 4331: res_pjsip_multihomed: Account for when the transport on a message is already correct

Joshua Colp reviewboard at asterisk.org
Wed Jan 14 15:39:42 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4331/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 9:39 p.m.)


Status
------

This change has been discarded.


Review request for Asterisk Developers.


Bugs: ASTERISK-24615
    https://issues.asterisk.org/jira/browse/ASTERISK-24615


Repository: Asterisk


Description
-------

The res_pjsip_multihomed module attempts to determine what transport a message should go out on and what addressing information should go into the message itself. In a scenario where multiple transports exist bound to the same IP address but a different port the code would incorrectly alter the transport and change the message to the wrong transport. This change makes it so that if the address of the existing transport on the message is already correct it is not altered.


Diffs
-----

  /branches/13/res/res_pjsip_multihomed.c 430545 

Diff: https://reviewboard.asterisk.org/r/4331/diff/


Testing
-------

Ran test and confirmed it failed without patch, passed with patch.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150114/958be843/attachment.html>


More information about the asterisk-dev mailing list