[asterisk-dev] [Code Review] 4337: testsuite: Verify that bad MACRO_RESULT/GOSUB_RESULT values don't create multiple DialEnd events

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4337/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 12:08 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Richard's findings.


Bugs: ASTERISK-24682
    https://issues.asterisk.org/jira/browse/ASTERISK-24682


Repository: testsuite


Description
-------

This patch updates the following tests to verify that mid-call Macros/GoSubs whose MACRO_RESULT/GOSUB_RESULT is set to an unknown value does not result in multiple DialEnd events. The test spawns an additional channel that calls a mid-call Macro/GoSub that returns, in its variable, a value that the Dial application does not understand. The test verifies that the two channels are bridged as expected, and that only a single DialEnd event is received.

Note: this patch covers the code change in r4336.


Diffs (updated)
-----

  /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/test-config.yaml 6274 
  /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/configs/ast1/extensions.conf 6274 
  /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/test-config.yaml 6274 
  /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/configs/ast1/extensions.conf 6274 

Diff: https://reviewboard.asterisk.org/r/4337/diff/


Testing
-------

With Asterisk 13, verified that the expected events are received with the patch on r4336.

With Asterisk 11, verified that the test completes successfully. Note that Asterisk 11 does not raise multiple AMI events.


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150114/66587260/attachment-0001.html>