[asterisk-dev] [Code Review] 4329: chan_pjsip: Add configure check for presence of 'pjsip_get_dest_info' function.
Mark Michelson
reviewboard at asterisk.org
Mon Jan 12 15:45:57 CST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4329/#review14165
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Michelson
On Jan. 12, 2015, 4:26 p.m., Joshua Colp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4329/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2015, 4:26 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-24665
> https://issues.asterisk.org/jira/browse/ASTERISK-24665
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> The 'secure' argument for chan_pjsip was changed in a previous commit to use the pjsip_get_dest_info function to determine if a secure transport is being used for signaling. This function, however, was added as of PJSIP 2.3 and is not in earlier versions. If an earlier version is installed the build may fail and loading the module may also fail.
>
> This change adds a configure check to determine if the pjsip_get_dest_info function is present. If it is not present the 'secure' argument won't work but everything else will continue as before.
>
>
> Diffs
> -----
>
> /branches/13/include/asterisk/autoconfig.h.in 430491
> /branches/13/configure.ac 430491
> /branches/13/configure UNKNOWN
> /branches/13/channels/pjsip/dialplan_functions.c 430491
>
> Diff: https://reviewboard.asterisk.org/r/4329/diff/
>
>
> Testing
> -------
>
> Ran configure check, confirmed it found the support.
>
>
> Thanks,
>
> Joshua Colp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150112/341dc064/attachment-0001.html>
More information about the asterisk-dev
mailing list