[asterisk-dev] [Code Review] 4306: res_pjsip_mwi: Change "MWI Subscription failed" message from warning to verb/4.
    Joshua Colp 
    reviewboard at asterisk.org
       
    Wed Jan  7 11:17:45 CST 2015
    
    
  
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4306/#review14107
-----------------------------------------------------------
I'd opt for LOG_NOTICE based on the conclusion in the other review.
- Joshua Colp
On Jan. 1, 2015, 11:29 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4306/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2015, 11:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The "MWI Subscription failed" message means the client is trying to subscribe to a mailbox that doesn't exist.  There's no need to clutter up logs with warnings for a client misconfiguration so I changed it to a verb/4.  
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip_mwi.c 430163 
> 
> Diff: https://reviewboard.asterisk.org/r/4306/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150107/c585c21e/attachment.html>
    
    
More information about the asterisk-dev
mailing list