[asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

[George Joseph]

> On Jan. 5, 2015, 5:11 p.m., Mark Michelson wrote:
> > I'm not sure I agree with this change. This can happen, like you said, due to MWI being indicated before an eventual registration. However, this can also happen due to a misconfiguration (either in Asterisk or the endpoint the MWI is being sent to) and not end up fixing itself without intervening. In the case of a misconfiguration, a warning goes a lot further towards pointing out the issue than a verbose message.
> > 
> > On the one hand, I can understand the annoyance in seeing a warning when things actually are fine, but I also don't want to withhold a message when something is genuinely wrong. I wonder if there is some sort of compromise that can be had here.
> 
> George Joseph wrote:
>     My feeling is that remote misconfiguration shouldn't cause warnings or errors but I don't see a way to tell the difference here.  We need a new log level like LOG_CONFIG :).
>     
>     If no one has an alternative by tomorrow, I'll discard the review.
> 
> Mark Michelson wrote:
>     Well, maybe a NOTICE is a decent compromise? Default logger.conf has NOTICEs appear in the CLI and most logs, but it doesn't carry the same tone of emergency that a warning or error would.

Works for me.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4314/#review14081
-----------------------------------------------------------


On Jan. 2, 2015, 3:41 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4314/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 3:41 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When res_pjsip loads and an endpoint auto-subscribes a mailbox for mwi, if a contact hasn't registered yet, res_pjsip_mwi spits out a warning.  This is a perfectly normal situation though and doesn't require something as serious as a warning.  It's also self correcting. The device will start getting mwi as soon as it registers.
> 
> This patch changes the warning to a verb/3.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip_mwi.c 430163 
> 
> Diff: https://reviewboard.asterisk.org/r/4314/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150106/f2af4aa2/attachment.html>