[asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

Kevin Harwell reviewboard at asterisk.org
Tue Jan 6 09:10:56 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4256/#review14085
-----------------------------------------------------------

Ship it!


I'll go ahead and ship it as this looks good to me, but you still have an open issue so not sure if you want to commit this until that gets answered/resolved.

- Kevin Harwell


On Dec. 31, 2014, 12:01 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4256/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 12:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24513
>     https://issues.asterisk.org/jira/browse/ASTERISK-24513
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test starts an attended transfer, converts to blonde mode by hanging up the transferer, and then fails the transfer by hanging up the transferee.  Then after allowing the recall attempt to complete, checks to insure that there are not leaked channels.
> 
> Improvements to channel_test_condition: count the actual channels listed in "core show channels" output to check for leaks.  Also added unittest.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/tests.yaml 6149 
>   /asterisk/trunk/tests/bridge/atxfer_fail_blonde/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_fail_blonde/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/channel_test_condition.py 6149 
> 
> Diff: https://reviewboard.asterisk.org/r/4256/diff/
> 
> 
> Testing
> -------
> 
> Currently fails while ASTERISK-24513 is not yet patched.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150106/b96f116e/attachment.html>


More information about the asterisk-dev mailing list