[asterisk-dev] [Code Review] 4305: pjsip cli: Fix sorting of contacts for 'pjsip list contacts'

Kevin Harwell reviewboard at asterisk.org
Fri Jan 2 16:31:08 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4305/#review14067
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Harwell


On Dec. 31, 2014, 5:18 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4305/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 5:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> For some reason I was using a hash container instead of a list to gather the contacts for 'pjsip list/show contacts' so even though I had a sort function, the output wasn't sorted.  This patch just changes the hash container to a list container and the contacts now appear sorted in the CLI.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip/location.c 430163 
> 
> Diff: https://reviewboard.asterisk.org/r/4305/diff/
> 
> 
> Testing
> -------
> 
> Eyeballed contact list before and after to confirm they were now sorted.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150102/73711c68/attachment.html>


More information about the asterisk-dev mailing list