[asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

Scott Griepentrog reviewboard at asterisk.org
Tue Nov 18 09:49:08 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4090/
-----------------------------------------------------------

(Updated Nov. 18, 2014, 9:49 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 5942


Repository: testsuite


Description
-------

This adds very basic valgrind support, which is convenient for manual test runs but does not (yet) include support for more automated valgrind usage. 

1) CLI flag '-V' enables valgrind (./runtests -V -t tests/test)

2) Minimal changes to testsuite, other improvements can be added later if desired

3) Valgrind output is picked up by error logging and shown after test run.

4) Unlike previous valgrind attempt, this one works fine on tests with multiple asterisk instances


Diffs
-----

  /asterisk/trunk/runtests.py 5733 
  /asterisk/trunk/lib/python/asterisk/test_case.py 5733 
  /asterisk/trunk/lib/python/asterisk/asterisk.py 5733 

Diff: https://reviewboard.asterisk.org/r/4090/diff/


Testing
-------


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141118/5ef42f0e/attachment.html>


More information about the asterisk-dev mailing list