[asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

[Scott Griepentrog]

> On Nov. 18, 2014, 8:18 a.m., Corey Farrell wrote:
> > Please discard my findings, they are minor.  I'd like to see this committed ASAP so further improvements can be made against it.

I like your idea of adding an option to pass valgrind options, but it needs to first be set to write logs to the appropriate run_x/asty directory so there isn't a conflict between multiple asterisk instances.  Then a simple parser added to check the log for critical issues that trigger a test failure, which then get included in the test results, even if in an abbreviated form.  Not sure how best to pass leak info other than just leaving it in the log though.


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4090/#review13791
-----------------------------------------------------------


On Oct. 16, 2014, 4:23 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4090/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 4:23 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds very basic valgrind support, which is convenient for manual test runs but does not (yet) include support for more automated valgrind usage. 
> 
> 1) CLI flag '-V' enables valgrind (./runtests -V -t tests/test)
> 
> 2) Minimal changes to testsuite, other improvements can be added later if desired
> 
> 3) Valgrind output is picked up by error logging and shown after test run.
> 
> 4) Unlike previous valgrind attempt, this one works fine on tests with multiple asterisk instances
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/runtests.py 5733 
>   /asterisk/trunk/lib/python/asterisk/test_case.py 5733 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 5733 
> 
> Diff: https://reviewboard.asterisk.org/r/4090/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141118/7694dce1/attachment.html>