[asterisk-dev] [Code Review] 4166: testsuite: tests/bridge/bridge_action leaves a channel open
Mark Michelson
reviewboard at asterisk.org
Thu Nov 13 10:30:16 CST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4166/#review13745
-----------------------------------------------------------
With the fix being made to the leaked bridge in Asterisk, is this change still required? Does hanging up self.channels[1] not result in self.channels[3] and the bridge being destroyed as expected?
- Mark Michelson
On Nov. 11, 2014, 8:37 p.m., Corey Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4166/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 8:37 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: testsuite
>
>
> Description
> -------
>
> self.channels[3] is not hung up, causing the Asterisk graceful shutdown to timeout. This causes the test to fail under REF_DEBUG mode and prevents coverage from seeing the code executed by this test.
>
>
> Diffs
> -----
>
> /asterisk/trunk/tests/bridge/bridge_action/bridge_action.py 5920
>
> Diff: https://reviewboard.asterisk.org/r/4166/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Corey Farrell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141113/e262a290/attachment-0001.html>
More information about the asterisk-dev
mailing list