[asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3867/#review13689
-----------------------------------------------------------

Ship it!


I'm fine with putting this in after looking at how it impacts behavior and real-world use. If you would like to fix the error that Jeremy mentioned feel free to. If you would like to also make an addition to the 'CHANGES' file that would be appreciated but not required. If not I'll take care of it upon commit in a few days (just giving time for anyone else to chime in).

I also apologize for how long this has taken. We strive for better but don't always hit where we want to be.

- Joshua Colp


On Aug. 3, 2014, 8:57 a.m., Michael K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3867/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2014, 8:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24128
>     https://issues.asterisk.org/jira/browse/ASTERISK-24128
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Load default dtls settings from [general settings]
> If peer has dtls enabled but misses some of the settings and they are set in default settings it would load them from there.
> It would be logical as most of sip settings work like that and as well as there is no way to use template in realtime and it would lead to copy paste same settings for every peer.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 419849 
> 
> Diff: https://reviewboard.asterisk.org/r/3867/diff/
> 
> 
> Testing
> -------
> 
> Test on development server (ast 11.11.0)
> 
> 
> Thanks,
> 
> Michael K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141105/83b3a1b0/attachment.html>