[asterisk-dev] [Code Review] 4146: res_pjsip: If an endpoint is associated with the dialog place it on the messag early

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4146/#review13674
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Nov. 3, 2014, 5:55 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4146/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 5:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1459
>     https://issues.asterisk.org/jira/browse/AST-1459
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently when distributing a message the code finds the dialog related to it and if present uses the information to send the message to the right serializer and to place the endpoint on the message. For the endpoint its presence is checked in the endpoint lookup step and placed into the expected endpoint spot. This causes problems as the dialog handling will occur before the endpoint lookup step, causing the endpoint to get lost and never placed on the message.
> 
> This change removes the endpoint lookup step requirement and places the endpoint in the expected spot in the distribution step. If the endpoint lookup step is actually invoked it just immediately returns if an endpoint is already present and does nothing.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/pjsip_distributor.c 427112 
> 
> Diff: https://reviewboard.asterisk.org/r/4146/diff/
> 
> 
> Testing
> -------
> 
> Added some code to determine if endpoint is present in the NAT handling code. Without the patch no endpoint would be present on the 200 OK response to an outgoing re-INVITE. With the patch an endpoint is present on the 200 OK response.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141104/abef98c0/attachment-0001.html>