[asterisk-dev] [Code Review] 4099: Optimistic SRTP Tests.

[opticron]

> On Oct. 29, 2014, 1:26 p.m., opticron wrote:
> > /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_optimistic_offer/sipp/offer.xml, line 45
> > <https://reviewboard.asterisk.org/r/4099/diff/2/?file=68484#file68484line45>
> >
> >     The other three new tests should have this type of check in the 200 response as well.
> 
> Joshua Colp wrote:
>     They... do?

optimistic_with_no_crypto/sipp/offer.xml is missing a test verifying lack of crypto.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4099/#review13621
-----------------------------------------------------------


On Oct. 21, 2014, 8:49 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4099/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 8:49 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This change removes 1 SIPP scenario from the old SRTP negotiation tests which would fail (because optimistic is now supported) and adds 4 new tests to cover the new optimistic support. These test do:
> 
> 1. Asterisk is configured with mandatory encryption and receives an offer with optimistic, it accepts the offer.
> 2. Asterisk is configured with optimistic encryption and receives an offer with optimistic, it accepts the offer.
> 3. Asterisk is configured with optimistic encryption and receives an offer with mandatory, it accepts the offer.
> 4. Asterisk is configured with optimistic encryption and receives an offer without any crypto, it accepts the offer.
> 
> The other SRTP negotiation tests cover the mandatory situations and other assorted crypto stuff.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 5766 
>   /asterisk/trunk/tests/channels/pjsip/srtp_negotiation/test-config.yaml 5766 
>   /asterisk/trunk/tests/channels/pjsip/srtp_negotiation/sipp/decline_not_enabled.xml 5766 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_optimistic_offer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_optimistic_offer/sipp/offer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_optimistic_offer/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_optimistic_offer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_no_crypto/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_no_crypto/sipp/offer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_no_crypto/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_no_crypto/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_mandatory_offer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_mandatory_offer/sipp/offer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_mandatory_offer/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_mandatory_offer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/mandatory_with_optimistic_offer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/mandatory_with_optimistic_offer/sipp/offer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/mandatory_with_optimistic_offer/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/mandatory_with_optimistic_offer/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4099/diff/
> 
> 
> Testing
> -------
> 
> Ran tests, confirmed happy.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141104/66916722/attachment.html>