[asterisk-dev] [Code Review] 4143: testsuite: Close HTTP connections when test is complete to prevent reported leaks in tests/phoneprov/res_phoneprov and tests/manager/config

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4143/#review13662
-----------------------------------------------------------

Ship it!


- Matt Jordan


On Nov. 2, 2014, 10:46 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4143/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2014, 10:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> HTTP connections left open when a test completes causes leaks to be reported by REF_DEBUG.  This ensures the connections are closed in two tests to ensure they pass with REF_DEBUG.  Remove import of syncami from tests/channels/SIP/pcap_demo since it's not actually used.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/phoneprov/res_phoneprov/run-test 5878 
>   /asterisk/trunk/tests/manager/config/ManagerConfigTest.py 5878 
>   /asterisk/trunk/tests/channels/SIP/pcap_demo/run-test 5878 
>   /asterisk/trunk/lib/python/asterisk/syncami.py 5878 
> 
> Diff: https://reviewboard.asterisk.org/r/4143/diff/
> 
> 
> Testing
> -------
> 
> Against 13, tests passed with no leaks reported.  Verified no other active test uses syncami.  Only tests/channels/SIP/nat_supertest used it but that test is disabled per ASTERISK-19565.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141103/51f5b370/attachment.html>