[asterisk-dev] [Code Review] 4140: res_http_websockets: Module reference decrease below zero

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4140/#review13659
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Nov. 2, 2014, 1:14 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4140/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2014, 1:14 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24480
>     https://issues.asterisk.org/jira/browse/ASTERISK-24480
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In Asterisk 12+ websocket_add_protocol_internal is used to add the "echo" protocol, but ast_websocket_remove_protocol is used to remove it.  This causes an extra call to ast_module_unref.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_http_websocket.c 426831 
> 
> Diff: https://reviewboard.asterisk.org/r/4140/diff/
> 
> 
> Testing
> -------
> 
> Found/tested with r4141.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141103/f1b66841/attachment.html>