[asterisk-dev] [Code Review] 3572: cli_aliases: Add 'pjsip reload' alias because it's nice. Plus, another for 11 syntax compatability.

[Mark Michelson]

> On May 28, 2014, 11:57 p.m., Paul Belanger wrote:
> > I'm all for adding the pjsip reload, but the context changes in the template seem unnecessary and potentially break systems that depend on the default config files.
> 
> Matt Jordan wrote:
>     Do you have an alternative to propose for naming Asterisk 12+ CLI aliases?
> 
> rnewton wrote:
>     Those syntax backwards compatibility templates are commented out in the config sample file. Only the "friendly" template is enabled. No system should be dependent on those.

[asterisk_twelve]
[asterisk_thirteen]

btw, I'm totally kidding.

I don't see how this would negatively affect systems.
First, this is a sample config; it's meant to be a sample of how things can be configured. IMO, it's something that is subject to change mid-release and should not affect running systems (do people really 'make samples' on an already installed and running system?).

Second, the change is entirely self-contained. The context names are being changed, and also the sample lines for enabling the sections are being changed. There is nothing outside of cli_aliases.conf that references this information. Someone who uses the sample config can just as easily uncomment the lines they care about as they could before.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3572/#review11989
-----------------------------------------------------------


On May 28, 2014, 8:14 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3572/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 8:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: https://issues.asterisk.org/jira/browse/ASTERISK-23654
>     https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-23654
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> 1. changed naming of included alias templates to avoid confusion between version names. For example, asterisk12 was for asterisk 1.2, so I changed it to asterisk_1dot2, so that later we can use asterisk_12 for Asterisk 12.
> 2. added alias for "features reload" to the template for Asterisk 11 style syntax template, as features reload was removed in 12, but you can still do "module reload features"
> 3. added alias for "pjsip reload" to the friendly template. It is shorter than "module reload res_pjsip.so" and if some are like me; I constantly forget that reloading chan_pjsip doesn't parse config. Remembering "pjsip reload" is just easier.
> 
> 
> Diffs
> -----
> 
>   /branches/12/configs/cli_aliases.conf.sample 414779 
> 
> Diff: https://reviewboard.asterisk.org/r/3572/diff/
> 
> 
> Testing
> -------
> 
> Tested the added aliases.
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140529/51c64882/attachment.html>