[asterisk-dev] [Code Review] 3516: media_formats: Move chan_sip over.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3516/#review11961
-----------------------------------------------------------



/team/group/media_formats-reviewed/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3516/#comment21863>

    This will leak the allocated format capability structures



/team/group/media_formats-reviewed/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3516/#comment21864>

    tpeercapability shouldn't be audio, should it?



/team/group/media_formats-reviewed/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3516/#comment21865>

    BUGBUG this



/team/group/media_formats-reviewed/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3516/#comment21866>

    BUGBUG this



/team/group/media_formats-reviewed/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3516/#comment21867>

    BUGBUG this


- Matt Jordan


On May 11, 2014, 7:46 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3516/
> -----------------------------------------------------------
> 
> (Updated May 11, 2014, 7:46 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change moves chan_sip over to the new media formats work.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed/include/asterisk/format_cache.h 413652 
>   /team/group/media_formats-reviewed/channels/sip/include/sip.h 413300 
>   /team/group/media_formats-reviewed/channels/chan_sip.c 413300 
> 
> Diff: https://reviewboard.asterisk.org/r/3516/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140522/f8951766/attachment.html>