[asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3494/
-----------------------------------------------------------

(Updated May 9, 2014, 5:29 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed issues.


Bugs: ASTERISK-22697
    https://issues.asterisk.org/jira/browse/ASTERISK-22697


Repository: Asterisk


Description
-------

This changes the implementation of UserEvent stasis messaging and adds additional features:

1) Existing channel_user_event stasis messaging replaced with new multi_object_blob in stasis_user.c
2) Multi object blob provides ability to signal blob + any number of channel, bridge, or endpoint snapshots
3) Changed existing Userevent() app to use new multi object blob - but still publishes to channel
4) Added ARI implementation of userevent as /ari/applications/{applicationName}/user/{eventName}
5) ARI generated userevent messages are published to application, and also to AMI if channel present


Diffs (updated)
-----

  /branches/12/rest-api/api-docs/events.json 413115 
  /branches/12/res/stasis/app.c 413115 
  /branches/12/res/res_stasis.c 413115 
  /branches/12/res/res_ari_events.c 413115 
  /branches/12/res/ari/resource_events.c 413115 
  /branches/12/res/ari/resource_events.h 413115 
  /branches/12/res/ari/ari_model_validators.c 413115 
  /branches/12/res/ari/ari_model_validators.h 413115 
  /branches/12/main/stasis_endpoints.c 413115 
  /branches/12/main/stasis_channels.c 413115 
  /branches/12/main/stasis.c 413115 
  /branches/12/main/manager_channels.c 413115 
  /branches/12/include/asterisk/stasis_channels.h 413115 
  /branches/12/include/asterisk/stasis_app.h 413115 
  /branches/12/include/asterisk/stasis.h 413115 
  /branches/12/apps/app_userevent.c 413115 

Diff: https://reviewboard.asterisk.org/r/3494/diff/


Testing
-------

Tested with valgrind to insure no invalid references.  Some leaks found which have been attributed to other code to be fixed separately.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140509/53d699ee/attachment.html>