[asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3402/
-----------------------------------------------------------

(Updated March 27, 2014, 1:42 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Corey's review, also added equivalent patch to manager sockets.


Bugs: SWP-6767
    https://issues.asterisk.org/jira/browse/SWP-6767


Repository: Asterisk


Description
-------

When running asterisk in a virtual machine, responses to ARI requests would frequently be missing.  A race condition related to closing the socket immediately after writing data onto it is resolved in this patch by insuring the output stream is flushed, and then informing TCP of the shutdown prior to the close.


Diffs (updated)
-----

  /branches/12/main/tcptls.c 411242 
  /branches/12/main/manager.c 411242 
  /branches/12/main/http.c 411242 

Diff: https://reviewboard.asterisk.org/r/3402/diff/


Testing
-------

Tested on Ubuntu server 12.04 with Sam's json api test from issue.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140327/1144ed46/attachment.html>