[asterisk-dev] [Code Review] 3399: PJSIP DTMF INFO Test

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3399/#review11392
-----------------------------------------------------------



./asterisk/trunk/tests/channels/pjsip/info_dtmf/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3399/#comment21039>

    These could use the same extension. Also, using timeouts is a bad way to structure a test. We have had plenty of issues with slow machines not running timing-based tests properly. Ideally, this would key off the last DTMF sent (or the entire sequence) to hangup the channel.


- opticron


On March 26, 2014, 9:02 a.m., Benjamin Keith Ford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3399/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 9:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23451
>     https://issues.asterisk.org/jira/browse/ASTERISK-23451
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test checks to see that a DTMF character can be received through a SIP packet while using PJSIP.
> 
> - Tests all DTMF characters (0-9 A-D # * !) and blank character
>   * Currently skipping the "!" and blank characters due to a bug *
> - Tests all DTMF characters with and without a specified duration
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/tests/channels/pjsip/tests.yaml 4889 
>   ./asterisk/trunk/tests/channels/pjsip/info_dtmf/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/info_dtmf/sipp/dtmf.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/info_dtmf/configs/ast1/pjsip.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/info_dtmf/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3399/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Keith Ford
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140327/01193c90/attachment.html>