[asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

[Geert Van Pamel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3349/
-----------------------------------------------------------

(Updated March 21, 2014, 8:32 a.m.)


Review request for Asterisk Developers, Corey Farrell, lmadensen, Matt Jordan, and wdoekes.


Changes
-------

Return userinfo when RFC 3966 does not include neither global number, nor context.
In this case hostport will not be available.
Avoid NULL string reference segmentation fault by adding explicit test && (userinfo != NULL) before strstr test.
The function strstr cannot handle NULL strings.


Bugs: ASTERISK-17179
    https://issues.asterisk.org/jira/browse/ASTERISK-17179


Repository: Asterisk


Description
-------

Implements RFC-3966 TEL URI incoming INVITE.

See https://issues.asterisk.org/jira/browse/ASTERISK-17179 for a description of the original isssue.

I have been patching all versions since Asterisk 1.6. I would like to include the code into the main trunk for version 13.

Previously Asterisk was failing with error on incoming IMS call:

Nov 13 17:52:05 NOTICE[27459]: chan_sip.c:6973 check_user_full: From address missing 'sip:', using it anyway

Nov 13 17:52:05 WARNING[27459]: chan_sip.c:6525 get_destination: Huh? Not a SIP header (tel:0987654321;phone-context=+32987654321)?

Reason: tel: protocol was not recognized.


Diffs (updated)
-----

  /trunk/channels/sip/reqresp_parser.c 410429 
  /trunk/channels/chan_sip.c 410429 

Diff: https://reviewboard.asterisk.org/r/3349/diff/


Testing
-------

Executed an incoming TEL URI INVITE connection.
CLI was present on the display and in the CDR file.
No errors on SIP debug output.


File Attachments
----------------

RFC-3966 tel URI patch
  https://reviewboard.asterisk.org/media/uploaded/files/2014/03/13/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt


Thanks,

Geert Van Pamel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140321/5f8afdaa/attachment.html>