[asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

[Scott Griepentrog]

> On March 18, 2014, 4:07 p.m., Corey Farrell wrote:
> > I would like to propose we backport ast_register_cleanup, use that to register format_attr_shutdown.  I meantioned this on #asterisk-dev last week, Matt said he could go for this approach if it's the best way to resolve this issue.  I've posted the patch to ASTERISK-23103.  I've tested with and without the patch, I'm unable to reproduce the crash with the patch.

Corey's alternate version is at https://reviewboard.asterisk.org/r/3376/


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3209/#review11255
-----------------------------------------------------------


On March 14, 2014, 1:35 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3209/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 1:35 p.m.)
> 
> 
> Review request for Asterisk Developers, Corey Farrell and n8ideas.
> 
> 
> Bugs: ASTERISK-23103
>     https://issues.asterisk.org/jira/browse/ASTERISK-23103
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Alternate method to more safely shutdown interfaces container.  Set interface global to null first to avoid possible race condition, and also double check interfaces prior to all uses.
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/format.c 410525 
> 
> Diff: https://reviewboard.asterisk.org/r/3209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140319/aefcce98/attachment.html>