[asterisk-dev] [Code Review] 3372: Allow local ICE candidates to be overridden with specified address

[Sean Bright]

> On March 18, 2014, 5:33 p.m., Sean Bright wrote:
> > I hadn't considered multihomed machines when I wrote this patch, so that might throw a wrench in this.

There are a log of things wrong with this.  Going to re-think it some.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3372/#review11282
-----------------------------------------------------------


On March 18, 2014, 5:04 p.m., Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3372/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 5:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When Asterisk's public IP address is known, such as in a static NAT topology, it still uses the machine's local interfaces as host candidates for ICE negotiation.  This patch introduces a new configuration option to rtp.conf - externaddr - that allows the user to configure their external IP address, similar to externaddr in sip.conf.  res_rtp_asterisk will then use this address as the host candidate rather than using the local interfaces and STUN.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_rtp_asterisk.c 410875 
>   /trunk/CHANGES 410875 
> 
> Diff: https://reviewboard.asterisk.org/r/3372/diff/
> 
> 
> Testing
> -------
> 
> Ran in a static NAT environment with externaddr set and media setup succeeded as expected.
> 
> 
> Thanks,
> 
> Sean Bright
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140319/ab99fe33/attachment.html>