[asterisk-dev] [Code Review] 3318: media_formats: Move bridges over.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3318/#review11279
-----------------------------------------------------------



/team/group/media_formats-reviewed/bridges/bridge_softmix.c
<https://reviewboard.asterisk.org/r/3318/#comment20902>

    And now this shows why you added that property.
    
    Since whether or not the marker bit is set isn't really specific to video, it does feel like this should be a more generic property. It does feel like this a bleed over of RTP into generic frames, which feels ugly... but I'm not sure how else we would represent this either.


- Matt Jordan


On March 8, 2014, 11:35 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3318/
> -----------------------------------------------------------
> 
> (Updated March 8, 2014, 11:35 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> These changes move the bridges over to the new media formats API.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed/bridges/bridge_softmix.c 409286 
>   /team/group/media_formats-reviewed/bridges/bridge_simple.c 409286 
>   /team/group/media_formats-reviewed/bridges/bridge_holding.c 409286 
> 
> Diff: https://reviewboard.asterisk.org/r/3318/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140318/2e15af52/attachment.html>