[asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

[zvision]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
-----------------------------------------------------------

(Updated March 17, 2014, 4:16 p.m.)


Review request for Asterisk Developers.


Changes
-------

More elegant nullable check.


Bugs: ASTERISK-23351
    https://issues.asterisk.org/jira/browse/ASTERISK-23351


Repository: Asterisk


Description
-------

This patch fixes handling of nullable int columns in update_realtime function. It checks if a value is empty and sets the column to NULL instead of '', which raises an error.
Additionally, it checks for existence of the keyfield column instead of the first parameter column.


Diffs (updated)
-----

  http://svn.asterisk.org/svn/asterisk/branches/1.8/res/res_config_pgsql.c 410663 

Diff: https://reviewboard.asterisk.org/r/3346/diff/


Testing
-------

Only tested for successful compilation. Someone needs to confirm that the patch works fine.


File Attachments
----------------

Patch version for branch 12
  https://reviewboard.asterisk.org/media/uploaded/files/2014/03/17/4564511f-3cf3-470a-844b-0f8fb1dd0ef6__res_config_pgsql.12.diff


Thanks,

zvision

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140317/13edcfb0/attachment.html>