[asterisk-dev] [asterisk-commits] mjordan: branch 11 r409990 - /branches/11/res/res_fax_spandsp.c

[Matthew Jordan]

On Mon, Mar 17, 2014 at 7:57 AM, Johann Steinwendtner
<steinwendtner at gmx.net> wrote:
> On 2014-03-17 13:27, Matthew Jordan wrote:
>>
>> On Mon, Mar 17, 2014 at 6:25 AM, Johann Steinwendtner
>> <steinwendtner at gmx.net> wrote:
>>>
>>> On 2014-03-06 02:58, SVN commits to the Asterisk project wrote:
>>>>
>>>>
>>
>>>
>>> Hello,
>>>
>>> is this patch using the g711 decode function from spandsp ? It is better
>>> to
>>> use g711_free(...), g711_release does actually nothing.
>>>
>>>
>>
>> Yes, it is using the spandsp library.
>>
>> The documentation for g711_release seems to imply at least that it
>> would free the g711 context [1], which is the object that is passed to
>> it. Why would g711_free be used over g711_release for this?
>>
>> [1]
>> http://spandsp.sourcearchive.com/documentation/0.0.5~pre4/g711_8h_ca377b1f9c4a8b8f3211e5cfad9954ab.html
>>
>
> Ah, ok. So it seems to be a compatibility problem with spandsp lib. I've
> checked 0.0.6 only, because it is installed
> on our machine which ran out of memory.
>
> http://spandsp.sourcearchive.com/documentation/0.0.6~pre12/g711_8c-source.html
>
> Regards
>
>
> Hans
>

Ugh. That stinks - there was no g711_free in 0.0.5.

Looks like we're going to need a patch for this that examines the
libspandsp version and uses one or the other.

-- 
Matthew Jordan
Digium, Inc. | Engineering Manager
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org