[asterisk-dev] [Code Review] 3359: res_stasis: Extend bridge type to include attributes

[Jonathan Rose]

> On March 14, 2014, 4:50 p.m., Jonathan Rose wrote:
> > /branches/12/rest-api/api-docs/bridges.json, lines 87-89
> > <https://reviewboard.asterisk.org/r/3359/diff/1/?file=56046#file56046line87>
> >
> >     Supposing we keep adding more of these flags which are compatible with each other, would that mean we would need to keep exploding these value lists every time we add a new option? This kinda seems to run contrary to the point of using a comma separated list.
> >     
> >     Also consider... 'dtmf_events,mixing', 'proxy_media,mixing', 'dtmf_events,proxy_media,mixing', etc.
> 
> Joshua Colp wrote:
>     Yeah, that's sort of the problem with this. I don't know of a good way to document that in the JSON. Suggestions?

Honestly, all I can think of at this point is that you would have to take out the allowableValues field and document it similar to how POST /applications/{applicationName}/subscription handles the eventSource field.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3359/#review11221
-----------------------------------------------------------


On March 14, 2014, 2:40 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3359/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 2:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23437
>     https://issues.asterisk.org/jira/browse/ASTERISK-23437
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change extends the bridge type for ARI bridge creation to be a comma separated list of attributes describing a bridge to create. I've added attributes for ensuring DTMF events occur and media is always proxied. The documentation has also been updated to include the various possible types.
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/bridges.json 410512 
>   /branches/12/res/res_stasis.c 410512 
>   /branches/12/CHANGES 410512 
> 
> Diff: https://reviewboard.asterisk.org/r/3359/diff/
> 
> 
> Testing
> -------
> 
> Using Swagger to create bridges of various types and confirmed that the resulting bridge technologies are as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140314/f4a6358e/attachment.html>