[asterisk-dev] [Code Review] 3331: Allows app_chanspy to whisper to a spyee's bridged peer (barge) even if the bridged party answers after initial spy invocation.

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3331/#review11217
-----------------------------------------------------------



/trunk/apps/app_chanspy.c
<https://reviewboard.asterisk.org/r/3331/#comment20849>

    RAII_VAR seems a little unnecessary for this function since it only has a single return path.



/trunk/apps/app_chanspy.c
<https://reviewboard.asterisk.org/r/3331/#comment20848>

    stray whitespace



/trunk/apps/app_chanspy.c
<https://reviewboard.asterisk.org/r/3331/#comment20847>

    Stray white space that needs cleaned up. Also, we always require curly braces for conditional code even if it's just a single line. Make sure you follow the coding guidelines: https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines


- Jonathan Rose


On March 13, 2014, 2:24 p.m., Robert Moss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3331/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 2:24 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23381
>     https://issues.asterisk.org/jira/browse/ASTERISK-23381
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Chanspy now can whisper to the spyee's "bridged party" (callee) (aka barging) even if the Spy started before the bridged party answered.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_chanspy.c 410469 
> 
> Diff: https://reviewboard.asterisk.org/r/3331/diff/
> 
> 
> Testing
> -------
> 
> Chanspy on an extension while the spyee's call is still ringing, after the bridged party answers, both spied on parties can hear the monitor.
> 
> 
> Thanks,
> 
> Robert Moss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140314/38b98758/attachment.html>